Skip to content

Remove datasetCopy field and associated references across Workspace models, API, and tests#1156

Merged
jreynard-code merged 1 commit intomainfrom
remove_datasetCopy_property_from_workspace
Mar 19, 2026
Merged

Remove datasetCopy field and associated references across Workspace models, API, and tests#1156
jreynard-code merged 1 commit intomainfrom
remove_datasetCopy_property_from_workspace

Conversation

@jreynard-code
Copy link
Copy Markdown
Member

@jreynard-code jreynard-code commented Mar 18, 2026

dataCopy was define as a Workspace property but was no longer user since v5.0.0.
From API point of we, it will have no impact, previous requests will still continue to work.
From generated clients (TS and python) users will have a error compatibility issue migrating from 5.0.0 to 5.0.1 client.

@csm-thu
Copy link
Copy Markdown
Member

csm-thu commented Mar 18, 2026

@jreynard-code I don't have enough knowledge of the back-end for this review, I'll let the other devs approve it :)
Btw, did you generate these changes with the GitHub Copilot agent or something similar? The build, test and lint workflows were triggered 15 times 😅
image

@sjoubert
Copy link
Copy Markdown
Contributor

The build, test and lint workflows were triggered 15 times 😅

Seems ok to me. They are triggered multiple time for each sub-module of the api, there's a matrix job in the workflows.

@csm-thu
Copy link
Copy Markdown
Member

csm-thu commented Mar 18, 2026

The build, test and lint workflows were triggered 15 times 😅

Seems ok to me. They are triggered multiple time for each sub-module of the api, there's a matrix job in the workflows.

Oh ok, thanks for the answer 😄

@csm-thu
Copy link
Copy Markdown
Member

csm-thu commented Mar 18, 2026

From generated clients (TS and python) users will have a error compatibility issue migrating from 5.0.0 to 5.0.1 client.

@jreynard-code I'm not sure I understand the impact of this... If a webapp uses client v5.0.0, will it work with a deployed API v5.0.1? (and vice-versa?)
Or do you mean only some calls to the API previously working with v5.0.0 will stop working in v5.0.1? (e.g. creating a workspace with the option datasetCopy defined)

Copy link
Copy Markdown
Contributor

@sjoubert sjoubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending a plan to deal with the breaking change. Since the parameter has no effect, I'm fine with it.

  • It should be documented in the release notes as a breaking change (both for the client and the api since the return data objects will no longer have the field)
  • We don't forget to include cleaning the database field in the migration tools from 5.0.0 -> 5.x.y

@jreynard-code
Copy link
Copy Markdown
Member Author

From generated clients (TS and python) users will have a error compatibility issue migrating from 5.0.0 to 5.0.1 client.

@jreynard-code I'm not sure I understand the impact of this... If a webapp uses client v5.0.0, will it work with a deployed API v5.0.1? (and vice-versa?) Or do you mean only some calls to the API previously working with v5.0.0 will stop working in v5.0.1? (e.g. creating a workspace with the option datasetCopy defined)

In a nutshell:

  • clients 5.0.0 will continue to work with API 5.0.0 and 5.0.1
  • clients 5.0.1 will continue to work with API 5.0.0 and 5.0.1
  • WorkspaceCreateRequest/WorkspaceUpdateRequest and Workspace objects will no more handle datasetCopy property in 5.0.1. So if this property is explicitly set in ETLs/Webapp, users will have to remove it once they use 5.0.1 clients

@jreynard-code jreynard-code force-pushed the remove_datasetCopy_property_from_workspace branch from 4e83b33 to a4e49a6 Compare March 18, 2026 14:14
@jreynard-code jreynard-code merged commit 8a3e066 into main Mar 19, 2026
42 checks passed
@jreynard-code jreynard-code deleted the remove_datasetCopy_property_from_workspace branch March 19, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants