Remove datasetCopy field and associated references across Workspace models, API, and tests#1156
Conversation
|
@jreynard-code I don't have enough knowledge of the back-end for this review, I'll let the other devs approve it :) |
Seems ok to me. They are triggered multiple time for each sub-module of the api, there's a matrix job in the workflows. |
Oh ok, thanks for the answer 😄 |
@jreynard-code I'm not sure I understand the impact of this... If a webapp uses client v5.0.0, will it work with a deployed API v5.0.1? (and vice-versa?) |
sjoubert
left a comment
There was a problem hiding this comment.
LGTM, pending a plan to deal with the breaking change. Since the parameter has no effect, I'm fine with it.
- It should be documented in the release notes as a breaking change (both for the client and the api since the return data objects will no longer have the field)
- We don't forget to include cleaning the database field in the migration tools from 5.0.0 -> 5.x.y
In a nutshell:
|
… models, API, and tests
4e83b33 to
a4e49a6
Compare

dataCopywas define as a Workspace property but was no longer user since v5.0.0.From API point of we, it will have no impact, previous requests will still continue to work.
From generated clients (TS and python) users will have a error compatibility issue migrating from 5.0.0 to 5.0.1 client.